[hatari-devel] "random" array read in SDLGui_DoDialog()

Laurent Sallafranque laurent.sallafranque at free.fr
Tue Jan 17 22:01:47 CET 2012


I've installed this patch and tested it.
It works well, but I haven't seen any difference.

Laurent


Le 15/01/2012 22:56, Eero Tamminen a écrit :
> Hi,
>
> On sunnuntai 15 tammikuu 2012, Eero Tamminen wrote:
>> Btw. When testing with some other things, I got also once this:
>> mudflap violation 1 (check/read): time=1326627178.463958 ptr=0x88e8d80
>> size=4
>> pc=0xb76d13bd location=`/home/eero/work/hatari/src/gui-sdl/sdlgui.c:741:6
>> (SDLGui_DoDialog)'
>>        /usr/lib/libmudflap.so.0(__mf_check+0x3d) [0xb76d13bd]
>>        src/hatari(SDLGui_DoDialog+0x3db4) [0x8300e74]
>>        src/hatari() [0x82eb21e]
>> Nearby object 1: checked region begins 1B after and ends 4B after
>> mudflap object 0x9bd3e90:
>> name=`/home/eero/work/hatari/src/falcon/nvram.c:56:14 nvram'
>>
>> But I wasn't able to reproduce it / steps leading to it. :-/
> It's really hard to reproduce, it (read access to incorrect memory)
> appears randomly when OKing options dialog, but I finally got it
> another time.
>
> Gdb says:
> (gdb) bt
> ...
> #6  0xb77b63bd in __mf_check () from /usr/lib/libmudflap.so.0
> #7  0x08355714 in SDLGui_DoDialog (dlg=0x8e9dea0, pEventOut=0x0) at
> /home/eero/work/hatari/src/gui-sdl/sdlgui.c:686
> #8  0x0833ea9e in DlgAlert_ShowDlg (text=<value optimized out>) at
> /home/eero/work/hatari/src/gui-sdl/dlgAlert.c:163
> #9  0x08107599 in Dialog_DoProperty () at
> /home/eero/work/hatari/src/dialog.c:57
> ...
>
> Unfortunately it seems that Gdb doesn't give for reads the actual
> code line number, just the function entry line.
>
> After looking at the SDLGui_DoDialog() code and wondering what could
> be doing under/over/random array reads, I think the attahed patch
> might fix it.
>
> I still wonder why current_object isn't set in the DoDialog main loop
> though.  Laurent?
>
>
> 	- Eero
>
>
> _______________________________________________
> hatari-devel mailing list
> hatari-devel at lists.berlios.de
> https://lists.berlios.de/mailman/listinfo/hatari-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.berlios.de/pipermail/hatari-devel/attachments/20120117/b05d3af7/attachment.html>


More information about the hatari-devel mailing list