[hatari-devel] Debugger crash changes / zeroing global variables

Nicolas Pomarède npomarede at corp.free.fr
Sun Jan 15 18:56:13 CET 2012


On 15/01/2012 16:23, Eero Tamminen wrote:
> Hi,
>
> On sunnuntai 15 tammikuu 2012, Eero Tamminen wrote:
>> (Just when sending this, I noticed your mail.
>> It may still be interesting though.)
>
> Nicolas, after looking at the patch, I checked the fix and it's
> still buggy:
> (gdb) bt
> ...
> #6  0xb76253bd in __mf_check () from /usr/lib/libmudflap.so.0
> #7  0x081cd30e in Video_CopyScreenLineColor () at
> /home/eero/work/hatari/src/video.c:1516
> #8  Video_EndHBL () at /home/eero/work/hatari/src/video.c:1725
> #9  Video_InterruptHandler_HBL () at /home/eero/work/hatari/src/video.c:1572
> #10 0x0831cef1 in m68k_run_1 (may_quit=1) at /home/eero/work/hatari/src/uae-
> cpu/newcpu.c:1776
> #11 m68k_go (may_quit=1) at /home/eero/work/hatari/src/uae-cpu/newcpu.c:1872
> #12 0x081399cf in M68000_Start () at /home/eero/work/hatari/src/m68000.c:246
> #13 0x0813fb46 in main (argc=4, argv=0xbf91e154) at
> /home/eero/work/hatari/src/main.c:782
> (gdb) print nLastVisibleHbl-nFirstVisibleHbl
> $1 = 400
> (gdb) print nHBL-nFirstVisibleHbl
> $2 = 280
> (gdb) print sizeof(HBLPaletteMasks)/sizeof(HBLPaletteMasks[0])
> $3 = 280
>
> Either you need to increase the array size enough, or add
> guards everywhere where you write to the HBLPaletteMasks.

Yes, I forgot to change this one ; but it should be less severe as it 
reads outside boudaries, instead of writing.

Can you try the attached patch to see if it fix the mudflap report ?


Nicolas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: palette.diff
Type: text/x-patch
Size: 694 bytes
Desc: not available
URL: <https://lists.berlios.de/pipermail/hatari-devel/attachments/20120115/d989de1c/attachment.bin>


More information about the hatari-devel mailing list