[hatari-devel] ifdef in changeset 3339 (TracksPerDisk_fixed)
Eero Tamminen
eerot at users.berlios.de
Sun May 22 18:45:27 CEST 2011
Hi,
On sunnuntai 22 toukokuu 2011, Nicolas Pomarède wrote:
> in change 3339, I understand moving TracksPerDisk_fixed to remove a
> warning, but why the "#if 0" ?
>
> I think it's quite useful to have a log when a disk has a boot sector
> that doesn't match the .st file size (the only problem with that printf
> is that it would be better to display it only once when a disk is
> inserted, not every time a sector is accessed).
The printf was commented out previously:
http://hg.berlios.de/repos/hatari/rev/616e3e78a36d
I didn't enable the printf as I didn't want to change what the code does.
I just changed the commented out stuff to be ifdeffed out.
(I think ifdef is a bit nicer, there's less lines to change when you
enable the stuff again & it's easier to find & notice such things.)
> This printf is quite useful, for example it shows why "omega rgb plasma"
> was not correctly booting in hatari 1.4
If you think it's useful, by all means remove the ifdef. :-)
- Eero
More information about the hatari-devel
mailing list