[hatari-devel] 68kDisass.c source indentation/TAB mess

[Eero Tamminen]

Hi,

On maanantai 02 toukokuu 2011, Nicolas Pomarède wrote:
> Le 01/05/2011 21:50, Eero Tamminen a écrit :
> > Has anybody objections if I fix the TAB/indentation mess in
> > 68kDisass.c?
> > 
> > I also thought changing it to use Uint32, ARRAYSIZE etc. stuff used
> > elsewhere in Hatari sources.
> > 
> > (Then maybe also try re-factoring a bit the 677 lines Disass68k()
> > monster function which uses "goto" to jump back to restart a while
> > loop...)
> 
> I would prefer if we leave it the way it was written by Markus ; if some
> improvements are made later that require modifying 68Dissas.c, I think
> Markus will be the only one to do it and he certainly prefers working on
> something that was formatted as it used to be when he first wrote it.
> 
> I agree we try to stick to some indent style when modifying already
> existing sources, but in the case of 68kDisass that Markus adapted to
> Hatari for us, I think that's OK if the whole file use a different
> indent style.
>
> Unless someone really wants to improve this part with some new
> functionnalities, I'm not sure commiting only "cosmetic" changes is a
> good idea.

The problem is that it needs functional improvements and Markus didn't seem
responsive to them.  I asked about them several times without any reply from
him (last time 19th of November).

For example:

* it currently handles only its own symbols, not the ones that user loads
  to the debugger.

* Showing profiler information on its own line (like I'm currently doing)
  looks really crappy and makes the disassembly hard to read.  It would
  be much better if disassembler would show profiler info better.

* Breakpoint code could use also some help from disassembler (function
  for getting next PC instruction address _without_ printing anything).

* Disassembly output being configurable from config file & debugger.


	- Eero