[hatari-devel] 68kDisass.c source indentation/TAB mess

[Nicolas Pomarède]

Le 01/05/2011 21:50, Eero Tamminen a écrit :
> Hi,
>
> Has anybody objections if I fix the TAB/indentation mess in 68kDisass.c?
>
> I also thought changing it to use Uint32, ARRAYSIZE etc. stuff used
> elsewhere in Hatari sources.
>
> (Then maybe also try re-factoring a bit the 677 lines Disass68k() monster
> function which uses "goto" to jump back to restart a while loop...)
>
>
> 	- Eero

Hi,

I would prefer if we leave it the way it was written by Markus ; if some 
improvements are made later that require modifying 68Dissas.c, I think 
Markus will be the only one to do it and he certainly prefers working on 
something that was formatted as it used to be when he first wrote it.

I agree we try to stick to some indent style when modifying already 
existing sources, but in the case of 68kDisass that Markus adapted to 
Hatari for us, I think that's OK if the whole file use a different 
indent style.

Unless someone really wants to improve this part with some new 
functionnalities, I'm not sure commiting only "cosmetic" changes is a 
good idea.

It's somewhat similar to uae's cpu core : the coding style is not the 
same, but as we imported those file in Hatari it's better to keep them 
as unchanged as possible in order to easily apply upstream patch when 
they appear in UAE/WinUAE.

Nicolas