[hatari-devel] Falcon emu and STE compatibility (D-Bug games)

Laurent Sallafranque laurent.sallafranque at free.fr
Mon Feb 21 21:42:27 CET 2011


I agree.

In the other hand, reading

      if (value == 0)
              falconBusMode = STE_BUS_COMPATIBLE;
      else
              falconBusMode = FALCON_ONLY_BUS;


helps to understand what is done here.

I'll keep it like this (I think this auto comment the code)

Regards,

Laurent



Le 21/02/2011 21:38, Eero Tamminen a écrit :
> Hi,
>
> On maanantai 21 helmikuu 2011, Laurent Sallafranque wrote:
>> Is it OK like this ?
> Yes.
>
>
> Looking at the function that's called:
> ----
> void IoMem_Init_FalconInSTeBuscompatibilityMode(Uint8 value)
> {
>       if (value == 0)
>               falconBusMode = STE_BUS_COMPATIBLE;
>       else
>               falconBusMode = FALCON_ONLY_BUS;
> ----
>
> If there are only on/off values, boolean would be a bit more natural though:
> ----
> void IoMem_Init_FalconInSTeBuscompatibilityMode(bool enabled)
> {
>       bFalconBusSteCompatible = enabled;
> ----
>
> But this is starting to go to nitpicking... :-)
>
>
> 	- Eero
> _______________________________________________
> hatari-devel mailing list
> hatari-devel at lists.berlios.de
> https://lists.berlios.de/mailman/listinfo/hatari-devel
>
>




More information about the hatari-devel mailing list