[hatari-devel] Falcon emu and STE compatibility (D-Bug games)

[Thomas Huth]

Am Sun, 20 Feb 2011 21:26:11 +0100
schrieb Laurent Sallafranque <laurent.sallafranque at free.fr>:

> Hi,
> 
> >  Pretty much well done now ... it's just a little bit confusing
> > that the
> STE mode is activated when "isFalconInSteMode" is false... when I read
> the code I would rather expect isFalconInSteMode == true would mean
> that the STE mode is activated...
> 
> 
> Yes, I thought about it. As the Ste compatibility mode is activated
> when the bit = 0, I've kept the same behaviour for the variable. But
> like you, I think it can be confusing.
> If you ask for, I change it.

Ok ... I would suggest to either do this change, or to rename the
variable, e.g. to "falconBusMode" or something similar. The "is" at the
beginning of the variable implies that it is a boolean variable which
should be true when the variable name condition is met. So either
renaming or changing the value should be fine, I think.

 Thomas