[hatari-devel] Falcon emu and STE compatibility (D-Bug games)

[Laurent Sallafranque]

Ok, no problem for me.

I'll merge the 2 functions into 1 asap.

Regards

Laurent



Le 19/02/2011 19:33, Nicolas Pomarède a écrit :
> Le 19/02/2011 15:10, Thomas Huth a écrit :
>> Am Sat, 19 Feb 2011 14:44:30 +0100
>> schrieb Laurent Sallafranque<laurent.sallafranque at free.fr>:
>>
>>> Hi,
>>>
>>> I've uploaded source for full Ste bus compatibility mode (Falcon mode
>>> only).
>>>
>>> I didn't want to create a new ioMemTabFalconSteMode table (no need to
>>> maintain 2 tables with the same parameters), so I've done it this way.
>>>
>>> Don't hesitate to tell me if you would have preferred another way.
>>
>> I think it is ok to do it this way, but ... the two IoMem_Init*()
>> functions are pretty much the same, except for the "Initialize STe
>> bus specific registers for Falcon" for-loop block.
>> Could you maybe merge that code block in the original IoMem_Init()
>> function instead, so that we do not have so much duplicated code?
>>
>
> I agree, we should avoid duplicating large block of code (well, it's 
> ok to do it at start as a proof of concept, but then we should try to 
> factorize code as much as possible, else it will be hard for other 
> people to read/maintain these parts)
>
> Nicolas
> _______________________________________________
> hatari-devel mailing list
> hatari-devel at lists.berlios.de
> https://lists.berlios.de/mailman/listinfo/hatari-devel
>
>