[hatari-devel] Compil hatari under windows (cygwin)

[Thomas Huth]

On Thu, 4 Nov 2010 22:33:31 +0200
Eero Tamminen <eerot at users.berlios.de> wrote:

> Hi,
> 
> On Thursday 04 November 2010, Laurent Sallafranque wrote:
> > I often compile hatari under windows (cygwin) to verify if
> > everything compiles well.
> > Actually, I get the following error :
> >
> > $make
> > [ 1%] Building C object
> > src/CMakeFiles/Floppy.dir/createBlankImage.c.o cc1: error:
> > unrecognized command line option "-Wno-empty-body"
> 
> How old GCC version you have?

I did some googling and it seems like this option has been introduced
around GCC 4.3 ...

> > I've removed the option and it compiles well.
> 
> Sure, as it's used to ignore one of the -Wextra warnings.
> 
> With a newer compiler Hatari will then output warnings (which Nicolas
> though weren't worth fixing as they aren't actual bugs).

If this option breaks some versions of GCC that are still in use in the
field, I think we should not use this. So I suggest to either remove
the -Wno-empty-body and then to fix the corresponding spots in our
source code, or to remove -Wextra and -Wno-empty-body together (and
maybe make compiling with -Wextra optional for example with a configure
switch instead).

 Thomas