[hatari-devel] WinUae CPU for hatari
Eero Tamminen
eerot at users.berlios.de
Fri Oct 22 12:44:43 CEST 2010
Hi,
I took a quick look at the changes. Some comments:
* Is WinUAE CPU actually using C++ exceptions (it had try, throw & catch)
(which would need to be emulated with variables)?
* There are a lot of "char*" -> "const char*" fixes, those should be pushed
to upstream...
* What's the problem with the large number of "L" changes, couldn't they be
handled with some single define ("#define L") in compat header?
- D(bug(L"MMU: map transparent mapping of %08x\n", *ttr));
+ //D(bug(L"MMU: map transparent mapping of %08x\n", *ttr));
* cpu/cpummu.c - why remove "static"?
-static struct mmu_atc_line atc_l2[2][ATC_L2_SIZE];
+struct mmu_atc_line atc_l2[2][ATC_L2_SIZE];
* cpu/events.h - STATIC_INLINE is already defined by compat.h...
-STATIC_INLINE int current_hpos (void)
+static inline int current_hpos (void)
* cpu/memory.c - has redundant white space changes
(It's better if you check for differences with diff -ub)
* cpu/custom.h - does that contain anything that would really be needed
by CPU emulation code? If not, I guess it could be replaced just with
an empty file with comment saying that it's there just to reduce
changes to WinAUE sources.
* If you take some file directly from uae-cpu/, it would be preferably if
it could be a separate commit from other winuae code modifications.
Such file could, at least eventually, be in some directory common to both
AUE & WinUAE code (at least maccess.h changes looked like this)
* for these kind of changes:
---
+ int i;
uae_u32 pc = m68k_getpc () + o;
for (;;) {
- for (int i = 0; i < 2; i++) {
+ for (i = 0; i < 2; i++) {
---
it's actually enough to do more local change of:
---
for (;;) {
- for (int i = 0; i < 2; i++) {
+ int i;
+ for (i = 0; i < 2; i++) {
---
(it's enough for declaration to be at the start of a block.)
* cpu/sysconfig.h:
- AUE configuration things are OK
- system configuration defines (like STDC_HEADERS) shouldn't be
WinAUE specific, but be created by CMake, otherwise they will be wrong
- Eero
More information about the hatari-devel
mailing list