[hatari-devel] New FileSelector

Eero Tamminen eerot at users.berlios.de
Wed Sep 22 23:09:48 CEST 2010


On Wednesday 22 September 2010, Laurent Sallafranque wrote:
> Ok, I've uploaded a cleaned version of the scrollbar :
> - I've removed the float w, h
> - I've updated code for this change
> - I've removed many casts
> There are still a few ones.
> Eero, would you have a look at the last casts and remove the ones you
> think are not useful ?

I think it looks fine now.

(Having such casts is more explicit, which is not a problem as long as they
aren't unnecessarily converting types.)

> Could someone test if I haven't broken anything ?

Works fine too!

Attached is a patch making sdl-gui const correct, but unfortunately only
way to do that without getting any warnings is a bit ugly (instead of using
a string static buffer, I need to do double malloc for it).  I'm not really
happy with that, but as editable text fields are used only in the file
selector, that might be bearable...


Btw. While testing this, I found a bug in Hatari:
- In floppy dialog, invoke "Create blank disk"
- Select "Create"
- Select "Okay"
  -> image created
- Select "Create"
- Select "Cancel"
- Select "Back"
  -> asks whether I want to insert the previously created disk
- Select "Drive A:"
  -> BOOM

This happens also in a version before our changes
(and in v1.4 release I assume).

	- Eero
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sdl-gui-consts.diff
Type: text/x-diff
Size: 5894 bytes
Desc: not available
URL: <https://lists.berlios.de/pipermail/hatari-devel/attachments/20100923/b0d6f787/attachment.diff>

More information about the hatari-devel mailing list