[hatari-devel] New FileSelector

[Laurent Sallafranque]

Le 13/09/2010 22:58, Eero Tamminen a écrit :
> Having an indicator about location & how many lines is visible is nice and
> very good improvement!
>    

Thanks,

>    
>> - Gem look and feel
>> - 17 lines displayed instead of 16 before
>>      
> But I think it's confusing to have file name above folder name.  GEM doesn't
> have that and neither has any of the other OSes I can think of.
>    

I agree here. I wanted to remove this file name and gain 2 more lines of 
display.
But how can one knows which file he has selected ?
(I would have to invert backgroud/foreground under mouse selection, 
which means new police ?)
> Having slightly GEMish look for one little part of the file selector doesn't
> match very well with rest of the file selector either.  The look of the
> corner boxes doesn't even match GEM (see attached screenshot)...
It's because I took as model the main GEM window instead of a GEM 
fileSelector.
I can remove the upper right icon (which is not useful).
> It looks even worse with no zooming (when you start Hatari with "-z 1").
>    
I didn't test it. I'll have a look

> ->  I suggest keeping the folder name above the file name like GEM has it.
>    

I can also return to previous Fileselector display if you want and just 
keep the scrollbar.
I found nicer to have a better look for the scrollbar, but the only 
interesting change in my code is the scrollbar function.
I also managed to gain 2 more display lines with this new look (path 
folders in the upper part of the selector)

Just tell me if you prefer the older look.

>> - upper left button for ".." folder
>>
>> Still to do :
>> - allow to scroll the scrollbar with the mouse (for now, it just
>> displays the current view of browsed files)
>>      
> One can already do that with scrollwheel which is OK if the list of files
> isn't huge.  But being able to grab the bar and drag would indeed be nice.
>    
I work on it (but it doesn't react as I would like for now)

> As to up&  down key repeat, I'd just ignore that.  To use the file selector
> one already needs to use mouse.  Having draggable bar in scrollbar would
> be much more useful.
>    
Ok, I forget this point.

> (for longer scrolls, page up&  down functionality compensates slightly for
> up&  down keys not repeating.)
>
>
>    
>> Question :
>>
>> - Do you like it ?
>>
>> - Can I remove the old ".." button, as now, you can  move to upper
>> folder with the upper left corner button ?
>>      
> It's still useful and you anyway need the other buttons.
>
> Maybe it's better at the left upper corner instead of the right one?
>    

?? it is already at the upper left corner ?
(I agree, I should remove the upper right icon which is not usefuil at all)


Regards,

Laurent