[hatari-devel] video.c happily overwriting Hatari memory and crashing (when user uses border pixel values < 16)

Eero Tamminen eerot at users.berlios.de
Fri Mar 19 21:10:10 CET 2010


Hi,

On Friday 19 March 2010, npomarede at corp.free.fr wrote:
>> I reviewed all the code using borders and I think the attached patch
>> should fix it.
...
> But I had to modify your patch, since it would not increase pVideoRaster
> by 2 or 4*2 bytes and this should be made in all cases, whether we can
> write in left screen border or not, else the display will be buggy.

Thanks, works fine!


> On Friday 19 March 2010, npomarede at corp.free.fr wrote: 
>> Btw. While testing this with Mind Rewind and More or Less Zero,
>> I noticed that former seems to be some pixels too much on left
>> while latter is (as already known) too much on the right.
>>
>> These were with or without the patch.
>
> Screen needs to be shifted 4 pixels to the right in 230 bytes overscan ;
> the 16 last pixels displayed in the right of the line may be "wrong" in
> that case, but they would be quite strange on a real ST too (due to the
> hi/lo stabilizer switch).
> And they could be even different when hscroll is used, but I didn't have
>
> the opportunity to check this on a real STE.
>
> So, apart from the last 16 pixels, I think the screen is correctly
> centered in 230 bytes overscan mode.
>
> What part of the screen do you take into account to see if mind review is
> too far to the left ?

Last pixels. It seemed that they were one line higher than they should.
See the attached screenshot of the right edge of screen.


Btw. Have you checked the last screen for Paradox X-mas 2004 demo?
	http://pouet.net/prod.php?which=15053

It both looks and sounds horrible.  Attached is a screenshot.


	- Eero
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mindwind.png
Type: image/png
Size: 1094 bytes
Desc: not available
URL: <https://lists.berlios.de/pipermail/hatari-devel/attachments/20100319/6777beb5/attachment.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: xmas2004.png
Type: image/png
Size: 13205 bytes
Desc: not available
URL: <https://lists.berlios.de/pipermail/hatari-devel/attachments/20100319/6777beb5/attachment-0001.png>


More information about the hatari-devel mailing list