[hatari-devel] video.c happily overwriting Hatari memory and crashing (when user uses border pixel values < 16)
npomarede at corp.free.fr
npomarede at corp.free.fr
Fri Mar 19 00:28:04 CET 2010
On Thu, 18 Mar 2010, Eero Tamminen wrote:
> Hi,
>
> On Thursday 18 March 2010, Eero Tamminen wrote:
>> It could handle the case when there are no (left/right) borders.
>>
>> I reviewed all the code using borders and I think the attached patch
>> should fix it.
>
> Btw. While testing this with Mind Rewind and More or Less Zero,
> I noticed that former seems to be some pixels too much on left
> while latter is (as already known) too much on the right.
>
> These were with or without the patch.
Screen needs to be shifted 4 pixels to the right in 230 bytes overscan ;
the 16 last pixels displayed in the right of the line may be "wrong" in
that case, but they would be quite strange on a real ST too (due to the
hi/lo stabilizer switch).
And they could be even different when hscroll is used, but I didn't have
the opportunity to check this on a real STE.
So, apart from the last 16 pixels, I think the screen is correctly
centered in 230 bytes overscan mode.
What part of the screen do you take into account to see if mind review is
too far to the left ?
Nicolas
More information about the hatari-devel
mailing list