[hatari-devel] Inconsistency when renaming file on GEMDOS drive

Eero Tamminen eerot at users.berlios.de
Wed Jan 13 21:52:50 CET 2010


Hi,

On Wednesday 13 January 2010, Uwe Seimet wrote:
> > While testing this a bit more, I found a couple of issues from my code
> > (in handling "../" in GEMDOS paths) which are fixed in the attached
> > patch along with fixes to too small host file name buffers in original
> > gemdos.c code (those didn't cause crashes, the GEMDOS emulation
> > wouldn't just work properly if resulting host paths would be over 256
> > chars long).
>
> With the patch I get this error message when starting Hatari:
>
> hatari: gemdos.c:1089: GemDOS_CreateHardDriveFileName: Assertion
> `nDestNameLen >= 4096' failed.

Strange, the new patch contained also the changes to make the required 
buffers in callers large enough.  You did apply all of it (those changes
were the last ones in it)?


> My GEMDOS drive path names are not longer than usual.

The assert is there to catch places that call this function with a
buffer that's too small to be able to contain all possible host file paths.

Eventually I will remove the assert and make
GemDOS_CreateHardDriveFileName() itself to allocate the buffer,
but that will happen only after the current patch gets into Hatari
as it will require quite a bit more changes.


	- Eero



More information about the hatari-devel mailing list