[hatari-devel] Command completion added to debugger

[Thomas Huth]

On Fri, 11 Sep 2009 08:55:13 +0300
Eero Tamminen <eerot at users.berlios.de> wrote:

> Btw. As debugger will at some point get IKBD debugging support, maybe
> it would make sense to split the debugger code up a bit?
> 
> I was thinking that I could (next week) move stuff to a "debugger/"
> subdirectory where would eventually be following files:
> 	breakcond.c
> 	debugcpu.c
> 	debugdsp.c
> 	debugikbd.c
> 	debugui.c  -- just the parsing

Do you just want to split up debugui.c, or do you also want to move the
code from falcon/dps_disasm.c and uae/newcpu.c? I wouldn't do the
latter since this code comes from external projects, so it's easier to
sync changes when you don't change it too much.

Also, I would call that directory just "debug" instead of "debugger",
then would could consider to move log.c there, too.

> I'll add also a separate "t" / "trace" command for setting tracing
> flags (it will make it easier to implement showing/completion for
> trace flags).

That's a good idea, always typing "setopt --trace ..." is quite
annoying.

> I could maybe also move:
> * test stuff from breakcond.c to top level tests/ dir.

Fine for me.

> * number base and range parsing from str.c back to debugui.c as that
> is only used in the debugger.

I don't think that they will be used for something else, so you could
move them back to the debugger, yes.

> * some of the stuff from falcon/dsp.c to debugger/debugdsp.c if I at
> some point add support for completing DSP register names (more of
>   a newbie "TAB" help command than really useful).

Register names are three letters max ... is it really useful to have
tab completion for that?

 Thomas