[hatari-devel] Hatari VDI mode colors issue

[npomarede at corp.free.fr]

On Fri, 14 Aug 2009, Thomas Huth wrote:

> On Fri, 14 Aug 2009 09:34:16 +0200
> "Thomas H." <th.huth at gmx.de> wrote:
>
>>> Thomas, maybe you have an idea what colors are used when in vdi
>>> mode.
>>
>> As far as I can tell, the problem is that in VDI mode, the code does
>> not call Video_StoreFirstLinePalette() anymore - it was called from
>> the HBL function, but since I've disabled HBLs in VDI mode, this does
>> not happen anymore. So HBLPalettes does not get initialized
>> correctly, and Screen_CreatePalette() then sets the wrong colors.
>> Since HBLPalettes is also set in Video_ColorReg_WriteWord() if
>> bUseHighRes was "false", the colors were still fine in non-monochrome
>> modes. But since this function is only used in ST & STE mode, the
>> colors might still be wrong when running VDI resolution in Falcon and
>> TT mode (I haven't tried it yet).
>>
>> One possible fix could be to call StoreFirstLinePalette() from the
>> VBL function when running in VDI resolution mode. I'll try that
>> tomorrow (don't have time today)...
>
> I came back a little bit earlier from work today, so I had the
> possibility to have a look at the problem again.
> I was right, calling StoreFirstLinePalette() from the VBL handler fixes
> the problem, so this should be fixed now in the current hg version.
>
> Thomas


Thanks,

so I think it closes the list of pending issues / regression if we want to
release 1.3 ?


Nicolas