[hatari-devel] Hatari patches for bitplane conversion

[Eero Tamminen]

Hi,

(Seems we're leaving for vacation later than I though, so there might still
be some mails from me today.  :-))

On Sunday 26 July 2009, Kåre Andersen wrote:
> I changed the calling in screen.s to
>
> if (pDrawFunction)
> {
> 	blitFrom = BLITFROM_INIT;
> 	blitTo = BLITTO_INIT;
>
> 	if(!bUseHighRes)
> 		Convert_StartFrame();            /* Start frame, track palettes */
>
> 	CALL_VAR(pDrawFunction);
> 	bScreenContentsChanged = (blitTo > blitFrom);
> }

As bScreenContentsChanged doesn't currently seem to be used anywhere
else than in the ST/e mode convertors and screen.c Screen_DrawFrame()
function, please remove it completely / change it to a local variable.

It seems that you can also remove pFrameBuffer->bFullUpdate check from
the convertors.  Screen_DrawFrame() does:
        /* Is need full-update, tag as such */
        if (pFrameBuffer->bFullUpdate)
                Screen_SetFullUpdateMask();

And as that already causes your code to update the whole screen through
AdjustLinePaletteRemap() call, the check for this flag in convertor is
redundant.  AFAIK it's also not set that often.


	- Eero