[hatari-devel] Hatari patches for bitplane conversion

[npomarede at corp.free.fr]

On Sat, 25 Jul 2009, Kåre Andersen wrote:

> Here we go :)
>
> I put the 32-bit converters into one file + header- shifter.c /
> shifter.h - made some inline functions (kicks in at -O3 atleast) in an
> attempt to refactor a bit and make it maintainable, and I did some
> testing.
>
> So far so good! Not able to find bad cases yet. Please review.
>
> Proper patches due soon - but the 16-bit converters and spec512 stuff
> will be implemented first.
>
> Also enclosed is a little screenshot of monochrome fullscreen updates
> with official Hatari 1.2.0 from Debian (ubuntu) compared to the new
> one....
>
> Have a great day!
>
> /Kåre
>


Thanks for your work ; have you considered writing a spec512 mode for med 
res ? Although not often used in demos, it's currently missing for eg Best 
Part of the Creation in Punish Your Machine or Highres demo by Paradox. If 
you get some some time for this, I will vote for your code :)

Also from a first read, your code doesn't look more complicated to 
read/maintain than the current one, which is nice (but the examples you 
sent are not handling spec512 mode, so this could add some complexity)

About the naming, I don't think shifter.[ch] is an appropriate name ; in 
fact, I think that it would be misleading regarding the other file names 
used as it would look like being related to hardware reg in $ff82xx (what 
video.c is doing now). Perhaps something like screenconvert.c ? But that's 
just a detail :)

Nicolas