[hatari-devel] DSP debug minor problems

[Eero Tamminen]

Hi,

On Saturday 11 July 2009, Laurent Sallafranque wrote:
> I've just seen that you've changed things into dsp.c debug code.
> You've removed the PC register (it's not really a dsp register as it's
> an implicit register),
> but I added it because it's useful when debugging to do a "dr pc=adr"
>
> I think there's just to add something like :
>
>         /* 16-bit status register */
>         { "PC",  &dsp_core.pc,  16, BITMASK(16) },

Added.  (I had removed it when the breakpoint condition code didn't yet
support other than 32-bit regs and forgot to add PC back later, sorry about
that.)


> I'm not sure of the SSH and SSL code you added :
>
>         { "SSH", &dsp_core.registers[DSP_REG_SP],  32, BITMASK(16) },
>         { "SSL", &dsp_core.registers[DSP_REG_SP],  32, BITMASK(16) },
>         { "SP",  &dsp_core.registers[DSP_REG_SP],  32, BITMASK(6) },

That's a typo, it should've used DSP_REG_SSH & DSP_REG_SSL defines
like DSP_DisasmRegisters() does.  Fixed now.

Anything else that should be fixed?


	- Eero