[hatari-devel] Conditional breakpoint code, please comment!

[Eero Tamminen]

Hi,

On Friday 03 July 2009, Eero Tamminen wrote:
> On Friday 03 July 2009, npomarede at corp.free.fr wrote:
> > By the way, why do I have this warning, it doesn't seem useful ?
>
> Currently 68k mask/bits default to 32-bits.  For now you can ignore it.
>
> > > b ( $ff820a).b = 0
> >
> > WARNING: mask ffffffff doesn't fit into 8 address/register bits

I just commited a version where this doesn't anymore give a warning:
- The right side inherits the bit width (here ".b") from the left side
  (and vice verse)
- As mask is not set, it's derived from the bit width


> After the DSP memory support, I'll check how to best inherit the mask
> from the other value, but only when it hasn't been explicitly set by the
> user.

But this will:
--------
b (d0).w=(a0).b

WARNING: mask ffff doesn't fit into 8 address/register bits
--------

The reason for this is that if there's no mask, it's derived from the bit
width.  And as the widths on both sides differ, it gives a warning.

I think this is acceptable.  It's much nicer to get sometimes (an obviously)
redundant warning than debug for a long time something where one
accidentally gave a breakpoint that can never be triggered...


	- Eero